747a078580
Deploy / deploy (push) Successful in 49s
On a free Saturday (nothing privileged already claims it, no active octave), the day's own identity is now "Our Lady's Saturday" rather than an anonymous ordinary-feria -- mirrors privileged-feria-minor exactly, per direct instruction: Semiduplex-or-higher still wins outright (Marian Saturday doesn't apply at all); below that (Simplex, and Vigil, both under semiduplex on the FeastClass scale) loses and is commemorated instead. Layered additively after decideOccurrence, same shape as applyOctaves -- never touches decideOccurrence's own rules. Needed a real winner identity (not just the plain temporal feria id) so day-label/antiphon/collect sourcing can recognize it -- added a temporal-feasts record purely for that, and taught getDayLabel to check it for any named temporal winner (a small, free improvement for Christmas/Pentecost's own labels too, previously unhandled). hours: build the duplex-majus+ Lauds psalmody override (per-feast) lauds-psalmody no longer unconditionally uses the plain weekday default: a duplex-majus-or-higher sanctoral winner, or Our Lady's Saturday (unconditional, no rank threshold -- it isn't competing with the weekday default the way a saint is), now substitutes its own proper psalm groups/antiphons/canticle. Per-feast, not per-Common, per direct instruction, even though most duplex-majus+ saints across the year don't have one authored yet and fall back to the plain weekday default until they do. Content for the worked example (St. Lawrence's own day) surfaced a real bug while sourcing it: st-lawrence-antiphon.yml had been read from the Roman/secular rite's own [Ant 1], not Monastic 1617's actual Benedictus antiphon for that day -- corrected from a fresh live query. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
110 lines
5.0 KiB
TypeScript
110 lines
5.0 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { resolveDay } from '../../src/calendar';
|
|
import { getDayCollect } from '../../src/hours/resolve-common';
|
|
|
|
// Clean per-annum years for these dates (no Sunday collision) — see
|
|
// data/calendar/saints/*.yml for per-saint source detail.
|
|
describe('August sanctoral pull (first pass)', () => {
|
|
it('St. Peter\'s Chains wins outright at Duplex majus with a real proper collect and antiphon, over a genuinely unwinnable stub', () => {
|
|
const day = resolveDay('2026-08-01');
|
|
expect(day.winner).toEqual({
|
|
kind: 'sanctoral',
|
|
id: 'st-peter-ad-vincula',
|
|
name: "St. Peter's Chains",
|
|
rank: 'duplex-majus',
|
|
});
|
|
expect(day.commemorations).toEqual([
|
|
{ kind: 'sanctoral', id: 'ss-machabees', name: 'Ss. Machabees, Martyrs', rank: 'simplex' },
|
|
]);
|
|
expect(getDayCollect(day).status.en).toBe('verified');
|
|
});
|
|
|
|
it('a saint normally blocked by the generic Saturday-of-Mary votive wins independently once the date falls on another weekday', () => {
|
|
const day = resolveDay('2027-08-02'); // a Monday
|
|
expect(day.winner).toEqual({
|
|
kind: 'sanctoral',
|
|
id: 'st-stephen-i',
|
|
name: 'St. Stephen I, Pope and Martyr',
|
|
rank: 'simplex',
|
|
});
|
|
expect(day.commemorations).toEqual([]);
|
|
});
|
|
|
|
it('St. Donatus wins outright every year in this app, unlike the real reference engine where he is occasionally displaced by a multi-day forward transfer this app does not model', () => {
|
|
// In the real Monastic 1617 engine, when Aug 3 (the Finding of St.
|
|
// Stephen) falls on a Sunday, it transfers forward past several
|
|
// higher-rank fixed feasts (Dominic, Our Lady of the Snows, the
|
|
// Transfiguration) and lands on Aug 7, displacing Donatus for that
|
|
// year (confirmed live for 2025 and 2031, both Aug-3-Sunday years).
|
|
// This app's transfer machinery doesn't chase a multi-day skip search
|
|
// like that -- see st-donatus.yml -- so Donatus wins here in every
|
|
// year, including ones where the real engine would displace him; a
|
|
// known, documented simplification rather than a guess.
|
|
const ordinary = resolveDay('2026-08-07');
|
|
const wouldHaveTransferredInReality = resolveDay('2031-08-07');
|
|
for (const day of [ordinary, wouldHaveTransferredInReality]) {
|
|
expect(day.winner).toEqual({
|
|
kind: 'sanctoral',
|
|
id: 'st-donatus',
|
|
name: 'St. Donatus, Bishop and Martyr',
|
|
rank: 'simplex',
|
|
});
|
|
}
|
|
});
|
|
|
|
it("the Vigil of St. Lawrence's own vigil rank forces primacy over a real, otherwise-unranked secondary saint", () => {
|
|
// 2025-08-09 is a Saturday -- collides with the generic Saturday-of-
|
|
// Mary votive this test isn't about (see tests/calendar/marian-
|
|
// saturday.test.ts); 2024 keeps it a plain midweek day.
|
|
const day = resolveDay('2024-08-09');
|
|
expect(day.winner).toEqual({
|
|
kind: 'sanctoral',
|
|
id: 'vigil-of-st-lawrence',
|
|
name: 'Vigil of St. Lawrence',
|
|
rank: 'vigil',
|
|
});
|
|
expect(day.commemorations).toEqual([
|
|
{ kind: 'sanctoral', id: 'st-romanus', name: 'St. Romanus, Martyr', rank: 'simplex' },
|
|
]);
|
|
});
|
|
|
|
it('St. Lawrence wins outright at Duplex II. classis, distinct from his own Vigil the day before', () => {
|
|
const day = resolveDay('2026-08-10');
|
|
expect(day.winner).toEqual({
|
|
kind: 'sanctoral',
|
|
id: 'st-lawrence',
|
|
name: 'St. Lawrence, Martyr',
|
|
rank: 'duplex-2-classis',
|
|
});
|
|
expect(getDayCollect(day).status.en).toBe('verified');
|
|
});
|
|
|
|
it("dates within St. Lawrence and the Assumption's own octaves still exclude the real secondary saint the source names (St. Clare, Aug 12) -- Clare herself isn't modeled yet -- but both octaves themselves (now modeled, see calendar/octaves.ts) correctly keep commemorating through them regardless", () => {
|
|
const clareDay = resolveDay('2025-08-12');
|
|
expect(clareDay.winner.kind).toBe('temporal');
|
|
expect(clareDay.commemorations).toEqual([{ kind: 'octave', id: 'st-lawrence', name: 'St. Lawrence, Martyr' }]);
|
|
// Aug 22 is the Assumption's own octave day (In Octava Assumptionis),
|
|
// Duplex, blocking Ss. Timothy/Hippolytus/Symphorian the same way --
|
|
// it's also day 8 of the Assumption's own octave.
|
|
const assumptionOctaveDay = resolveDay('2025-08-22');
|
|
expect(assumptionOctaveDay.winner.kind).toBe('temporal');
|
|
expect(assumptionOctaveDay.commemorations).toEqual([
|
|
{ kind: 'octave', id: 'assumption', name: 'The Assumption of the Blessed Virgin Mary' },
|
|
]);
|
|
});
|
|
|
|
it('the Beheading of St. John the Baptist wins outright at Duplex with a real proper collect and antiphon, over a genuinely unwinnable stub', () => {
|
|
const day = resolveDay('2025-08-29');
|
|
expect(day.winner).toEqual({
|
|
kind: 'sanctoral',
|
|
id: 'decollation-of-st-john-baptist',
|
|
name: 'The Beheading of St. John the Baptist',
|
|
rank: 'duplex',
|
|
});
|
|
expect(day.commemorations).toEqual([
|
|
{ kind: 'sanctoral', id: 'st-sabina', name: 'St. Sabina, Martyr', rank: 'simplex' },
|
|
]);
|
|
expect(getDayCollect(day).status.en).toBe('verified');
|
|
});
|
|
});
|