Extend the source-file fallback to Frances of Rome/Bibiana, fix a real Agatha/Lucy gap
Deploy / deploy (push) Successful in 56s
Deploy / deploy (push) Successful in 56s
Follow-up to the previous commit: applies the same "read the fileref directly, no live query required" fix to St. Frances of Rome and St. Bibiana, whose own filerefs simply hadn't been derived yet (they predate the Kalendaria-table work this session built). Both resolve to common-of-a-virgin, same as several of the 15 fixed previously. Also swept every saint on the calendar (not just this batch's own lineage) for any other still-missing collect or Benedictus antiphon, which turned up a real, older gap: St. Agatha and St. Lucy's own file comments already documented "resolves honestly missing... despite propers being set" -- written before collectCommon existed as a mechanism at all. Agatha's own [Oratio] is a name-substituted reference confirmed identical to the already-existing collect-c6.yml template, so collectCommon was simply wired in. Lucy's own [Oratio] references a different Common formula unedited, with her own [Name] section supplying the whole descriptive phrase a plain name field would otherwise need the template for -- written as her own st-lucy-collect.yml rather than a new single-use template, since she's the only current user of that unedited form. St. Clare showed up in the same sweep but is a false positive: her real content lives in a separate commemoration-bundle file, used via a different code path the sweep's synthetic-winner methodology doesn't exercise -- already fully authored, no gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -17,7 +17,11 @@ describe('February sanctoral pull (first pass)', () => {
|
||||
expect(getDayCollect(day).status.en).toBe('verified');
|
||||
});
|
||||
|
||||
it("a saint with a proper antiphon but no proper collect resolves the collect as honestly missing", () => {
|
||||
it('a saint with a proper antiphon but no proper collect resolves the collect via its Common category (collectCommon), not missing', () => {
|
||||
// Her own [Oratio] is @Commune/C6::s/N\./Agathæ/ -- a name-substituted
|
||||
// reference, not unique text -- confirmed identical to collect-c6.yml's
|
||||
// own template; wired via collectCommon (2026-08), postdating this
|
||||
// saint's own original authoring, which is why this used to be missing.
|
||||
const day = resolveDay('2029-02-05'); // St. Agatha
|
||||
expect(day.winner).toEqual({
|
||||
kind: 'sanctoral',
|
||||
@@ -25,7 +29,9 @@ describe('February sanctoral pull (first pass)', () => {
|
||||
name: 'St. Agatha, Virgin and Martyr',
|
||||
rank: 'semiduplex',
|
||||
});
|
||||
expect(getDayCollect(day).status.en).toBe('missing');
|
||||
const collect = getDayCollect(day);
|
||||
expect(collect.status.en).toBe('verified');
|
||||
expect(collect.text.en).toContain('Agatha');
|
||||
});
|
||||
|
||||
it('the two Chair-of-Peter feasts (Rome, Antioch) are separate records with independently authored, matching content', () => {
|
||||
|
||||
@@ -35,6 +35,20 @@ describe('getDayCollect', () => {
|
||||
expect(collect.status.la).toBe('verified');
|
||||
});
|
||||
|
||||
it("resolves St. Lucy's own collect, read directly from her source file rather than a shared template (2026-08)", () => {
|
||||
// Her own [Oratio] is @Commune/C7a, unedited -- unlike
|
||||
// collect-c6a.yml's own C7a-derived text, no "Vírginis tuæ" insertion
|
||||
// -- so her own [Name] section supplies the whole descriptive phrase,
|
||||
// making her file's own text effectively proper even though it's
|
||||
// built from a Common formula underneath. No English in the source at
|
||||
// all, so status.en stays draft.
|
||||
const day = resolveDay('2025-12-13');
|
||||
expect(day.winner).toMatchObject({ kind: 'sanctoral', id: 'st-lucy' });
|
||||
const collect = getDayCollect(day);
|
||||
expect(collect.status).toEqual({ la: 'verified', en: 'draft' });
|
||||
expect(collect.text.en).toContain('Lucy');
|
||||
});
|
||||
|
||||
it('resolves as honestly missing for a saint with neither a proper collect nor a Common fallback authored', () => {
|
||||
// Every real saint in data/calendar/saints/*.yml now has either a
|
||||
// proper collect or a collectCommon fallback (see TODO.md's
|
||||
@@ -73,6 +87,17 @@ describe('genuinely unwinnable stubs still get a Benedictus antiphon (2026-08)',
|
||||
expect(ben.status).toEqual({ la: 'verified', en: 'verified' });
|
||||
});
|
||||
|
||||
it('resolves via the same fallback for a saint from the *original*, pre-Kalendaria-table 109-saint pass', () => {
|
||||
// St. Frances of Rome and St. Bibiana predate the 94-saint batch's
|
||||
// collectCommon/minorHoursCommon mechanism entirely, but the same
|
||||
// file-read method applies once a fileref is derived for them too --
|
||||
// Frances of Rome's own file points to C7a (a whole-file inherit of
|
||||
// C7, just relabeled "of a Widow"), resolving to the same
|
||||
// common-of-a-virgin text as St. Felicitas above.
|
||||
const ben = getBenedictusAntiphon(syntheticSanctoralDay('st-frances-of-rome'));
|
||||
expect(ben.status).toEqual({ la: 'verified', en: 'verified' });
|
||||
});
|
||||
|
||||
it("resolves its own file's [Ant 1] as draft, not verified, when it can't be checked against a live rendering", () => {
|
||||
// Ss. Euphemia, Lucy, and Geminian -- her own file *does* have an
|
||||
// [Ant 1], but St. Alexius (a winnable saint checked earlier in this
|
||||
|
||||
Reference in New Issue
Block a user