13 Commits

Author	SHA1	Message	Date
will	1a1b296c5f	Model the Paschaltide alleluia suffix on Common-category antiphons ... Live-querying settled the "sometimes 1, sometimes 2 allelúja" question: categories without their own dedicated Paschaltide source-text chain (Confessor-Bishop/Doctor, Abbot, Virgin, ...) get a mechanical single suffix appended at render time, not a rank/octave-dependent count. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-13 14:19:32 -04:00
will	ffaa797940	Author Benedictus antiphon + P/T/S/N Commons for 66 propers:null saints ... Continues the 94-saint batch this collects pass unblocked. Raw Commune/*.txt fields don't reliably match what the engine actually renders per hour -- same lesson as the collects pass, confirmed again: no CommuneM/*.txt file defines explicit per-hour antiphon fields for any category this batch needed, and the already-authored common-of-a-confessor-bishop content (from the original 29-saint pass) doesn't match Commune/C4.txt's own raw [Ant 1] either, since it was live-query-sourced rather than read from the file directly. Fixed by querying web/cgi-bin/horas/officium.pl directly (local Perl, not a network fetch) for one representative saint per Common category, with every representative's title verified against an accent-insensitive name-stem match before its content is trusted -- caught a stale-date bug this way: St. Emerentiana's stored clean-year comment actually rendered St. Hilary of Poitiers's office that year. Cross-querying multiple saints per nominal SaintRecord.common category found the real liturgical groupings are coarser (Martyr-Bishop and Martyr; Abbot, Confessor-not-Bishop, and Confessor; Virgin-Martyr, Virgin, and Holy Woman all render identical minor-hour text) but not uniformly so (Pope-Martyrs render distinct allelúja-toned text from plain Several-Martyrs; the Dedication of the Basilicas of Ss. Peter and Paul draws from the Dedication Common, not its nominal common-of-an-apostle at all). Net: 7 new shared Common categories plus the pre-existing common-of-a-confessor-bishop (which also needed a new Benedictus-antiphon file of its own) cover 66 of the 94 saints. New mechanism: SaintRecord.benedictusCommon, with getBenedictusAntiphon falling back to it the same way getDayCollect already falls back to collectCommon -- no name-substitution needed here, since every Common category in current use renders name-free Benedictus-antiphon text. Also fixes a real bug this surfaced: getMinorHourOverrideId gated all Prime/Terce/Sext/None lookup behind the same duplex-majus+ threshold Lauds' own psalmody override uses, on the assumption that only a strong feast carries its own minor-hour content -- live-querying proved that wrong (a winning Semiduplex saint still renders its own antiphons, not the ferial default). Lauds' psalmody override itself stays majus+-gated correctly, since it's a much bigger per-saint commitment this batch doesn't add a Common fallback for. Ss. Ursula and Companions deliberately left without a minor-hour Common: her collect template has no other calendar member to verify a shared text against, and she can never be queried directly (a genuinely unwinnable stub) -- left honestly unauthored rather than guessed. The other 26 of the 94 (own proper collect, from the collects batch) still need their own individually-authored Benedictus antiphon, same shape as the original 109-saint pass -- not done in this pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-13 08:58:13 -04:00
will	6bb4c6a80f	Author day collects for all 94 propers:null saints via Kalendaria tables ... Blind per-date source-file reading (Sancti/SanctiM MM-DD.txt) turned out unreliable for collect authorship: those files are era-merged, carrying centuries of accumulated saints behind rubric-conditional gating, so a naive read often returned a saint canonized long after 1617 instead of the Monastic-Tridentine-era one actually on this calendar (St. Didacus instead of All Saints of the Benedictine Order, St. Rose of Lima instead of Ss. Felix and Adauctus, etc). Fixed by pulling from web/www/Tabulae/Kalendaria/'s own era-specific calendar tables (1570.txt Tridentine base + M1617.txt's Monastic diffs) instead, cross-validated against the pre-1955/Divino Afflatu chain (1888->1906->1939->1954) as a corroborating signal. Cross-referencing all 205 existing saint records against this table confirmed 204/205 were already correctly placed -- the earlier live-query verification work was sound, only blind file-reading was flawed -- so no sanctoral-calendar.yml corrections were needed, just the collect content itself. Two collect shapes came out of the 94: 34 proper collects (own YAML file, Latin verified against source, English translated+draft where the source lacked it) and 60 resolved via a new Common-collect templating mechanism -- SaintRecord.collectCommon/collectName plus substituteName() in resolve-common.ts, filling a template's {N} placeholders positionally from the saint's own declined name, across 21 new common/collect-c*.yml templates named after the source's own C-numbering. St. Michael's Sep 29 propers resolved via its whole-file @Sancti/05-08 inheritance (Apparition of St. Michael, May 8). St. Martha's plural- template default was overridden to the singular collect-c6a since she's one person, not a pair. Also fixes a latent bug this surfaced: getDayCollect looked up `${collectCommon}-collect`, but collect-c*.yml files are id'd as `collect-c2` etc with no such suffix -- caught by a smoke test where every one of the 93 non-Michael saints resolved as missing. 4 pre-existing tests updated: they asserted specific saints (St. Benedict, St. Romanus Abbot, St. Anthony Abbot) had no authored collect, which is no longer true; resolve-common.test.ts's generic "missing" case now uses a synthetic day/winner since no real unauthored saint remains as an example. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-13 08:19:28 -04:00
will	6bab6047c1	Author full Christmas-Octave Sunday content, fix a temporal-id override gap ... christmas-octave-sunday previously had only its Benedictus antiphon authored -- no Lauds psalmody override or office bundle, no Prime/Terce/ Sext/None content at all. Adds the full set: Lauds psalmody (3 psalms + Canticle of the Three Young Men + Laudate, all distinct antiphons), Lauds capitulum/versicle/hymn ("A solis ortus cardine"), and Prime/Terce/ Sext/None antiphons+chapters (Terce/Sext/None only, matching Gal 4:1-2/4:4-5/4:7 -- the same reading the raw Monastic Tridentinum 1617 source file gives for this Sunday). Real code gap found and fixed along the way: getMinorHourOverrideId (hours/resolve-common.ts) only checked the sanctoral branch of resolveOfficeWinner's result, so a named temporal feast in ALWAYS_OVERRIDE_TEMPORAL_IDS (marian-saturday, christ-the-king) got a Lauds psalmody override but silently never a Prime/Terce/Sext/None one, however much was authored for it. Fixed by mirroring getPsalmodyOverrideFor's own temporal-id branch (hours/lauds.ts), and christmas-octave-sunday added to that set. Content sourced from a "Divino Afflatu 1954" live query rather than Monastic Tridentinum 1617, since 1617 has no real identity of its own for this Sunday under its own calendar rules on most Dec 26-29 dates (only the collect, already authored separately, happened to be pulled from a date where 1617 did render it) -- consistent with this app's stated precedent of following D.A. for calendar/precedence even while keeping 1617's shape for the hours themselves elsewhere. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 16:16:33 -04:00
will	bcae61568a	Add Paschaltide-variant fallback for minor-hour Commons ... Confirms and formalizes what TODO.md had flagged as an open question: the reference engine's own source has explicit Paschaltide variants (Commune/C1p.txt, C2p.txt, C3p.txt -- "tempore Paschali") for exactly 3 of its 12 Common categories -- Apostles, a Martyr-Bishop, Several Martyrs -- a real liturgical restriction of Alleluia/victory imagery to apostles and martyrs, not a coincidence. resolveMinorHourAntiphon/resolveMinorHourChapter now try a `${minorHoursCommon}-paschaltide` variant first whenever day.season is eastertide/ascensiontide/pentecost (the same three-season window as Compline's own Regina Caeli table, since "tempore paschali" runs through the Pentecost octave in both), falling back to the plain Common when no variant is authored. common-of-apostles-paschaltide (7 files) ported directly from the reference engine's own Commune/C1p.txt source files rather than live-queried, then cross-checked against st-mark's already-authored, live-queried content -- identical except one antiphon's asterisk, which the source places one word earlier; corrected to match. st-mark and st-john-before-the-latin-gate's duplicate per-saint files removed entirely; ss-philip-and-james's chapter files removed (its antiphons stay proper). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 16:03:06 -04:00
will	735f677815	Extract shared Commons for Prime/Terce/Sext/None minor-hour content ... A systematic diff across all 29 duplex-majus+ saints' P/T/S/N files found real shared-Common groups beyond the pairs noticed in passing while authoring them. Extracted into shared data/propers/common/{hour}-antiphon- common-of-*.yml / {hour}-capitulum-common-of-*.yml files and wired via a new SaintRecord.minorHoursCommon field, with resolveMinorHourAntiphon/ resolveMinorHourChapter falling back to it when a saint has no proper file of their own. Deliberately a separate field from the existing (previously unused) `common` field: the minor hours don't always draw from the same Common category as the saint's overall classification -- both Chair of St. Peter feasts are `common: common-of-an-apostle` by rank, but their P/T/S/N content is Common of a Confessor Bishop (Peter considered as bishop of that see). Four groups extracted (87 duplicate files collapsed to 21 shared ones), each confirmed byte-identical via diff first: common-of-apostles (8 saints, all 4 hours), common-of-a-confessor-bishop (Chair of Peter pair share antiphons+chapters, Martin of Tours shares only chapters), common- of-the-bvm (Nativity BVM + Immaculate Conception's Sext/None/Terce chapters -- the Assumption's own stay proper, different reading + proper versicles), and common-of-st-peter (St. Peter ad Vincula + Ss. Peter and Paul, not a real Common category, just genuinely identical Petrine content). Deliberately left un-extracted: St. Mark, St. John Before the Latin Gate, and Ss. Philip and James share identical text that live-checking shows is Paschaltide-seasonal (all three landed within the Easter octave weeks on their queried dates, despite disagreeing `common` classifications) rather than a fixed per-saint-category Common -- folding it into the same mechanism would misrepresent season-contingent content as timeless. Left as individually-authored files; flagged in TODO.md as needing a real Paschaltide-awareness mechanism this app doesn't have yet for any hour. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 15:47:13 -04:00
will	2658a2b94e	Fix splitNamedAntiphon silently upgrading draft text to verified ... Every antiphon that goes through the incipit/full split -- which is every antiphon across every hour -- lost its real status the moment it passed through here: splitNamedAntiphon hardcoded `verified` on its output via verifiedText(), regardless of what the source's actual status was. Concretely, this meant St. Scholastica's antiphon (I translated it myself, no English existed in the source), Matthias's and several other apostles' reworded English, and Gregory the Great's translated antiphon all silently rendered as if fully verified -- losing the "unverified draft text" UI marker (src/ui/styles.css's .text-draft, a dashed underline + tooltip) that's supposed to distinguish "copied straight from the source" from "Claude's own rendering." Fixed by having splitNamedAntiphon accept a real ResolvedText and carry its per-language status through unchanged to both outputs, instead of silently upgrading everything to verified. Callers whose antiphon never had a status field to begin with (plain weekday-default antiphons and Lauds psalmody overrides -- neither type tracks status at all, always implicitly verified by the source file's own live-checked convention) now wrap with verifiedText() explicitly at the call site, rather than that assumption being buried inside splitNamedAntiphon itself. resolveMinorHourAntiphon (Prime/Terce/Sext/None's override lookup) now returns a full ResolvedText for the same reason. Verified end-to-end with St. Scholastica's real draft-English antiphon, both via a direct unit test and visually in the browser (the dashed underline now shows correctly under her Benedictus antiphon). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 11:34:21 -04:00
will	397f31f4fc	Implement octave-vs-octave precedence, and fix a real day-label bug it surfaced ... When more than one octave is active on a day with no temporal standing of its own (St. Lawrence's and the Assumption's genuinely overlap every Aug 16-17), which one governs the day's content/label is now decided by rank comparison instead of "whichever started first" (an accident of insertion order). Per direct instruction: - Highest effective rank wins outright; every other active octave still gets commemorated, same as a single octave already outranking a weak rival saint. - A rank tie goes to whichever octave started more recently -- day 1 of a new octave needs to be fully present, the whole point of it starting. No real tied-rank case exists yet to verify this empirically, unlike everything else here -- documented in TODO.md as a stated decision, not a live finding. New OctaveConfig.closingDayRank (default duplex): an octave's own final day ("in Octava") is elevated above its ordinary in-between rank -- live-verified as a real, general pattern (both St. Lawrence's Aug 17 and the Assumption's Aug 22 show as Duplex, above their otherwise-Semiduplex ordinary days), not a one-off. This elevation is *why* Lawrence's octave beats the Assumption's on their one real overlap day despite the Assumption being the far higher-ranked feast overall. Feeds both the existing rival-saint threshold and the new octave-vs-octave comparison. calendar/octaves.ts gains resolveActiveOctave (+ pickWinningOctave, the comparison itself factored out for direct unit testing against synthetic data, since no real tied-rank overlap exists to test against yet). hours/resolve-common.ts's resolveOfficeWinner and calendar/day-label.ts both now call it instead of each keeping their own "activeOctavesFor(...) [0]" logic. That consolidation surfaced a real, independent bug: getDayLabel never checked temporalCategory at all before choosing an octave name, unlike resolveOfficeWinner -- found while testing the real Aug 16 overlap (a Sunday that year, where the temporal Sunday has standing and should win outright). Live-verified counterexample: the Christmas Octave's own stack (Dec 30) was wrongly labeled "3rd Day within the Octave of The Holy Innocents" instead of the correct plain temporal label -- the real title never names any of the four stacked octaves there. Fixed by sharing the exact same ordinary-feria gate resolveOfficeWinner already had, so the two can no longer disagree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 09:38:06 -04:00
will	5f4cf33776	Add per-feast overrides to Prime/Terce/Sext/None; fill Lauds' own Lawrence office bundle ... Prime/Terce/Sext/None had no per-feast override mechanism at all before this -- their psalm antiphon always fell back to the plain weekday default and their chapter was always a single fixed per-annum/per-weekday text, regardless of what was actually being celebrated, even on a saint's own actual feast day (not just during an octave). Confirmed live (Monastic Tridentinum 1617) that St. Lawrence has his own real antiphon and chapter at every one of these hours, both on his own day and throughout his octave. New shared mechanism in hours/resolve-common.ts: getMinorHourOverrideId (duplex-majus+ threshold, kept in sync with Lauds' own so it's one shared backlog), resolveMinorHourAntiphon, resolveMinorHourChapter -- all resolveOfficeWinner-aware, so an octave day gets the same override as the feast's own actual day. Prime additionally needed isSundayOrFeastOffice (its capitulum/Preces Sunday-vs-ferial choice) made octave-aware -- live-verified Prime's capitulum stays the Sunday/feast form throughout the octave too, so no new file was needed there, just reaching the existing one correctly. Also fills in Lauds' own still-missing Lawrence office bundle (capitulum/responsory/hymn/versicle) -- flagged in TODO.md as worth fixing "even before tackling the other 32" and still not done until now. Authored real content for St. Lawrence across all five hours from live queries. The same ~31-saint backlog (TODO.md) now applies uniformly across Lauds and the four hours fixed here. Also documents a real, found-not-fixed gap: when two octaves overlap with no temporal standing to yield to (St. Lawrence's and the Assumption's genuinely overlap every Aug 16-17), this app currently picks whichever started first, which happens to match the live engine on Aug 17 (Lawrence's own elevated final "Octave Day" outranks the Assumption's ordinary octave-day strength) but only by coincidence, not a real rank comparison -- proposed design written up in TODO.md pending a decision on scope. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 08:05:08 -04:00
will	143244203d	Fix octave-day office content: use the octave's own feast, not the plain ferial ... Real, multi-part bug found by looking closely at today's rendering (day 3 of St. Lawrence's octave, St. Clare commemorated): the psalmody antiphons, hymn, chapter/responsory/versicle, Benedictus antiphon, and day collect were all keyed off `day.winner` directly, which stays the plain temporal identity (post-pentecost-11) throughout an octave -- St. Lawrence's own already-authored psalmody override and collect never engaged on any day but his actual feast day. Live-verified (Tridentine 1910, 2026-08-12) that the whole office on an ordinary octave day actually comes from the octave's own feast ("{ex Commune aut Festo}" / "{ex Proprio Sanctorum}"), with a *weaker* commemorated saint (Clare) getting a separate Ant+V/R+collect block of her own alongside it. Fixed with a new resolveOfficeWinner(day) in hours/resolve-common.ts, used everywhere getDayCollect/getDayCollects/getBenedictusAntiphon/ getPsalmodyOverrideFor used to read day.winner directly. Deliberately gated on temporalCategory === 'ordinary-feria' (the day has no standing of its own) rather than "any active octave" -- the Christmas Octave's own stacked octaves are the live-verified counterexample where the *temporal* day keeps the office instead, each octave becoming its own separate commemoration block (not yet modeled, flagged in TODO.md). Also fixes the ferial Preces gate (added in the previous commit) to exclude active octaves the same way the suffrages already do -- live-verified "Preces Feriales{omittitur}" on the same date. getDayCollects now renders a sanctoral commemoration as a real Ant+V/R+collect bundle when authored (${propers}-commemoration.yml), not just a bare, unlabeled collect -- the old rendering was indeed the confusing "PRAYER / (translation pending)" block spotted today, which was St. Clare's placeholder with no indication whose it was or why. Authored her real commemoration bundle and standalone collect from the same live query rather than leaving it pending. One correction to a guess floated mid-session: the Benedictus antiphon does NOT go to the commemorated saint (Clare) -- live-verified it stays with the octave's own feast (Lawrence's "In cratícula"), same as everything else in the primary office; only the separate commemoration block is Clare's. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-12 07:44:39 -04:00
will	5830e4cfd2	hours: build Lauds ... Opening versicle; Ps 66 (fixed, no antiphon at all); the weekday- variable psalm groups (Ps 50 plus 1-2 more, framed by their own antiphon each, wholesale-substituted by Sunday's Ps 50+117-share-one- antiphon shape); the weekday OT canticle; the Laudate psalms (148-150) under one more shared antiphon; the weekday chapter/responsory/hymn/ versicle bundle; the Benedictus (framed by a day-resolved antiphon, same incipit-or-full/full-repeat shape as Compline's Nunc Dimittis); the Kyrie/Pater-noster short litany; the day's collect(s) — winner plus one per commemoration, via the new getDayCollects; the four Tridentine suffrages (omitted on a Double-or-higher feast); the conclusio; the closing versicle (the silent Our Father that precedes it isn't re-rendered, its text having already appeared once at the short litany); and the closing Marian antiphon, reusing Compline's own mechanism exactly. Known, deliberate gap, not yet fixed: the psalmody doesn't model the Commune/feast override real practice applies on a Semiduplex-or-higher day (substituting an entirely different psalm+canticle set) — every day currently gets the plain ferial weekday distribution regardless of who wins. That's a separate, larger propers-authoring task (a full Common-of-Saints psalm set per Common). Also a simplification in getDayCollects: each collect in a multi- collect day renders as its own complete "Let us pray ... Amen." block, rather than the more compressed real form (one "Let us pray," only the last collect's doxology). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-11 11:45:25 -04:00
will	81440de832	hours: add the day's-collect resolver ... Terce/Sext/None's Oratio is the day's own Proper-of-season/-saints collect, not a fixed text — getDayCollect() resolves it from the LiturgicalDay's winner (temporal id or sanctoral saint's propers), falling through to an honest "missing" status for saints that don't have authored propers yet. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-10 13:50:24 -04:00
will	ec448bc35b	compline: build the full hour, sharing Prime's resolver helpers ... Ordo is Monastic 1617 as a base, with deliberate Tridentine 1906 additions: the "In manus tuas" short responsory, the Nunc Dimittis with its "Salva nos" antiphon, the fuller Preces (Monastic's own is shorter), and Lent's "Christe, qui lux es et dies" hymn replacement (English translation marked draft, pending a real historical one). Psalms 4, 90, 133 are fixed daily with real verified text, unlike Prime's weekday-rotated psalms. The closing Marian antiphon now picks Alma Redemptoris Mater / Ave Regina Caelorum / Regina Caeli / Salve Regina by real season, using the calendar work from the previous commit — except Ave Regina Caelorum's own window (Candlemas through the day before Maundy Thursday) doesn't align to any single season value, so that one case checks the real date directly instead of going through the by-season table. resolve-common.ts extracts the resolve/status/doxology/antiphon helpers Prime already had into something Compline can share; a few propers files lose their "prime-" prefix now that both hours use them.	2026-08-10 05:27:40 -04:00