Author Benedictus antiphon + P/T/S/N Commons for 66 propers:null saints
Deploy / deploy (push) Successful in 56s
Deploy / deploy (push) Successful in 56s
Continues the 94-saint batch this collects pass unblocked. Raw Commune/*.txt fields don't reliably match what the engine actually renders per hour -- same lesson as the collects pass, confirmed again: no CommuneM/*.txt file defines explicit per-hour antiphon fields for any category this batch needed, and the already-authored common-of-a-confessor-bishop content (from the original 29-saint pass) doesn't match Commune/C4.txt's own raw [Ant 1] either, since it was live-query-sourced rather than read from the file directly. Fixed by querying web/cgi-bin/horas/officium.pl directly (local Perl, not a network fetch) for one representative saint per Common category, with every representative's title verified against an accent-insensitive name-stem match before its content is trusted -- caught a stale-date bug this way: St. Emerentiana's stored clean-year comment actually rendered St. Hilary of Poitiers's office that year. Cross-querying multiple saints per nominal SaintRecord.common category found the real liturgical groupings are coarser (Martyr-Bishop and Martyr; Abbot, Confessor-not-Bishop, and Confessor; Virgin-Martyr, Virgin, and Holy Woman all render identical minor-hour text) but not uniformly so (Pope-Martyrs render distinct allelúja-toned text from plain Several-Martyrs; the Dedication of the Basilicas of Ss. Peter and Paul draws from the Dedication Common, not its nominal common-of-an-apostle at all). Net: 7 new shared Common categories plus the pre-existing common-of-a-confessor-bishop (which also needed a new Benedictus-antiphon file of its own) cover 66 of the 94 saints. New mechanism: SaintRecord.benedictusCommon, with getBenedictusAntiphon falling back to it the same way getDayCollect already falls back to collectCommon -- no name-substitution needed here, since every Common category in current use renders name-free Benedictus-antiphon text. Also fixes a real bug this surfaced: getMinorHourOverrideId gated all Prime/Terce/Sext/None lookup behind the same duplex-majus+ threshold Lauds' own psalmody override uses, on the assumption that only a strong feast carries its own minor-hour content -- live-querying proved that wrong (a winning Semiduplex saint still renders its own antiphons, not the ferial default). Lauds' psalmody override itself stays majus+-gated correctly, since it's a much bigger per-saint commitment this batch doesn't add a Common fallback for. Ss. Ursula and Companions deliberately left without a minor-hour Common: her collect template has no other calendar member to verify a shared text against, and she can never be queried directly (a genuinely unwinnable stub) -- left honestly unauthored rather than guessed. The other 26 of the 94 (own proper collect, from the collects batch) still need their own individually-authored Benedictus antiphon, same shape as the original 109-saint pass -- not done in this pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,6 +1,12 @@
|
||||
import { describe, expect, it } from 'vitest';
|
||||
import { resolveDay } from '../../src/calendar';
|
||||
import { getDayCollect, splitNamedAntiphon } from '../../src/hours/resolve-common';
|
||||
import {
|
||||
getDayCollect,
|
||||
getBenedictusAntiphon,
|
||||
resolveMinorHourAntiphon,
|
||||
resolveMinorHourChapter,
|
||||
splitNamedAntiphon,
|
||||
} from '../../src/hours/resolve-common';
|
||||
import type { LiturgicalDay } from '../../src/calendar/types';
|
||||
|
||||
describe('getDayCollect', () => {
|
||||
@@ -38,6 +44,33 @@ describe('getDayCollect', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('minorHoursCommon/benedictusCommon fallback (2026-08, the 94 propers:null saints)', () => {
|
||||
it('a below-duplex-majus saint still gets a real Benedictus antiphon and P/T/S/N content via its Common category', () => {
|
||||
// St. Anacletus, Semiduplex -- below the duplex-majus+ threshold that
|
||||
// gates a *proper* psalmody override (hours/lauds.ts's
|
||||
// getPsalmodyOverrideFor), but getMinorHourOverrideId no longer
|
||||
// requires that threshold for the shared-Common fallback (see its own
|
||||
// doc comment for why: live-querying confirmed even a winning Simplex
|
||||
// saint keeps proper/Common minor-hour content, not the ferial
|
||||
// default).
|
||||
const day = resolveDay('2028-07-13');
|
||||
expect(day.winner).toMatchObject({ kind: 'sanctoral', id: 'st-anacletus' });
|
||||
expect(getBenedictusAntiphon(day).status).toEqual({ la: 'verified', en: 'verified' });
|
||||
expect(resolveMinorHourAntiphon('prime', day, {}).status.la).toBe('verified');
|
||||
expect(resolveMinorHourChapter('terce', day, 'terce-capitulum-ferial').status.la).toBe('verified');
|
||||
});
|
||||
|
||||
it('a Duplex-II-classis saint with no proper minor-hour content of its own still resolves via the Common, not just below-majus saints', () => {
|
||||
// Ss. Placid and Companions -- confirms the fallback isn't only
|
||||
// reached by low ranks; a real major feast with no *proper*
|
||||
// Prime/Terce/Sext/None file authored falls through to its
|
||||
// minorHoursCommon (common-of-several-martyrs) exactly the same way.
|
||||
const day = resolveDay('2025-10-05');
|
||||
expect(day.winner).toMatchObject({ kind: 'sanctoral', id: 'ss-placid-and-companions' });
|
||||
expect(resolveMinorHourAntiphon('none', day, {}).status.la).toBe('verified');
|
||||
});
|
||||
});
|
||||
|
||||
describe('splitNamedAntiphon', () => {
|
||||
it('carries a verified status through to both the incipit and full forms', () => {
|
||||
const { incipit, full } = splitNamedAntiphon({
|
||||
|
||||
Reference in New Issue
Block a user