will/vu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Christmas Octave Sunday's occurrence precedence (was backwards)
Deploy / deploy (push) Successful in 51s
Details

Browse Source 
christmastide's Sunday was coded privileged-sunday (Advent's own tier),
which live-checking against the reference engine shows is wrong: on
every one of the three real collision dates (St. Stephen/John/Holy
Innocents, all Duplex-II-classis, falling on the Sunday within the
Octave) the saint wins outright and the Sunday is merely commemorated --
the reverse of what privileged-sunday would produce (Sunday stays
primary, saint just gets a nod). St. Silvester (plain Duplex, Dec 31)
confirms the same live. Reclassified to ordinary-sunday, which matches
all four checked cases: Duplex+ wins outright (Stephen/John/Innocents/
Silvester), Semiduplex still transfers off the Sunday rather than
winning (St. Thomas Becket, unaffected by the fix either way), and a day
with no saint at all resolves to the Sunday cleanly.

Found while pulling christmas-octave-sunday's own Benedictus antiphon
from the reference engine's dedicated Tempora/Nat1-0 proper and noticing
this app's own occurrence resolution didn't match what the live engine
showed for the Sunday's real collision dates.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Will Estes
2026-08-12 06:30:46 -04:00
parent 73672853ef
commit ff81a6fe52
3 changed files with 90 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/data/calendar/temporal-categories.yml
+15 -1
View File
@@ -52,7 +52,21 @@ bySeason:
# Canterbury, Semiduplex, wins outright within the Octave (Dec 29) in the
# real Monastic 1617 engine, which `privileged-feria`'s Duplex+ threshold
# would wrongly forbid.
christmastide: { sunday: privileged-sunday, feria: privileged-feria-minor }
#
# The Sunday itself is `ordinary-sunday`, NOT `privileged-sunday` —
# originally miscoded as privileged-sunday (Advent's own Sundays' tier),
# which was backwards: live-verified against all six possible collision
# dates (Dec 26 St. Stephen, 27 St. John, 28 Holy Innocents — all
# Duplex-II-classis — plus 31 St. Silvester, plain Duplex), every one of
# them wins outright over the Sunday, which is merely commemorated in
# return — exactly ordinary-sunday's Duplex+ rule, and the reverse of
# privileged-sunday's (which would keep the Sunday primary and only nod
# to the saint). Dec 29 (St. Thomas Becket, Semiduplex) still transfers
# off the Sunday rather than winning, and a day with no saint at all
# (e.g. Dec 30) still resolves to the Sunday cleanly — both of those
# match ordinary-sunday too, so nothing here actually depended on the
# stronger tier.
christmastide: { sunday: ordinary-sunday, feria: privileged-feria-minor }
epiphanytide: { sunday: ordinary-sunday, feria: ordinary-feria }
septuagesima: { sunday: privileged-sunday, feria: ordinary-feria }
lent: { sunday: privileged-sunday, feria: ordinary-feria }