will/vu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Scope renderCitation to the currently displayed languages

Browse Source 
renderCitation deduplicated a text's citation values across every
stored language, not just the ones actually being rendered. Once a
citation's La/En abbreviations genuinely differ (e.g. "Jac 1:12" vs.
"Jas 1:12", or "Sap. 10:10" vs. "Wis. 10:10"), both survived the
dedupe and got joined together regardless of view mode, leaking the
other language's abbreviation into a single-language display.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VFGHb4XMe6Wya4pGpPhEEi
This commit is contained in:
Will Estes
2026-08-29 07:33:48 -04:00
parent 7ab517cbe3
commit b163f502b8
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ui/hour-view.ts
+13 -7
View File
@@ -26,12 +26,18 @@ function renderColumns(resolved: ResolvedText | ResolvedVerse, languages: readon
}
// Scripture quotations always carry a full citation (book, chapter, verse) —
// shown once, deduplicated across languages when they happen to match.
function renderCitation(text: ResolvedText): string {
// shown once per currently-displayed language, deduplicated when they
// happen to match (e.g. a plain "Psalm 118" citation reused verbatim in
// both columns) — restricted to `languages` so a language-specific
// abbreviation (Latin "Jac 1:12" vs. English "Jas 1:12") never leaks into
// a single-language view.
function renderCitation(text: ResolvedText, languages: readonly string[]): string {
if (!text.citation) {
return '';
}
const values = [...new Set(Object.values(text.citation).filter((v): v is string => Boolean(v)))];
const values = [
...new Set(languages.map((lang) => text.citation![lang]).filter((v): v is string => Boolean(v))),
];
return values.length ? `<p class="ordo-part-citation">${escapeHtml(values.join(' / '))}</p>` : '';
}
@@ -64,7 +70,7 @@ function renderPart(part: ResolvedPart, languages: readonly string[]): string {
return `
<section class="ordo-part ordo-part-${part.kind}">
<h3 class="ordo-part-label">${hourLabel(part.kind)}</h3>
${renderCitation(part.text)}
${renderCitation(part.text, languages)}
${renderColumns(part.text, languages)}
</section>
`;
@@ -93,7 +99,7 @@ function renderPart(part: ResolvedPart, languages: readonly string[]): string {
return `
<section class="ordo-part ordo-part-lesson">
${renderLessonLabel(part.label, languages)}
${renderCitation(part.text)}
${renderCitation(part.text, languages)}
${renderColumns(part.text, languages)}
${part.responsory ? `<div class="ordo-part-responsory">${renderColumns(part.responsory, languages)}</div>` : ''}
</section>
@@ -110,7 +116,7 @@ function renderPart(part: ResolvedPart, languages: readonly string[]): string {
return `
<section class="ordo-part ordo-part-lesson ordo-part-gospel">
<h3 class="ordo-part-label">Gospel</h3>
${renderCitation(part.text)}
${renderCitation(part.text, languages)}
${renderColumns(part.text, languages)}
${part.source ? `<p class="ordo-part-citation">${escapeHtml(part.source)}</p>` : ''}
${part.responsory ? `<div class="ordo-part-responsory">${renderColumns(part.responsory, languages)}</div>` : ''}
@@ -170,7 +176,7 @@ function renderPart(part: ResolvedPart, languages: readonly string[]): string {
<section class="ordo-part ordo-part-canticle">
${part.antiphon ? renderColumns(part.antiphon, languages) : ''}
<h3 class="ordo-part-label lang-columns lang-columns-${languages.length}">${titleCols}</h3>
${renderCitation(part.text)}
${renderCitation(part.text, languages)}
${renderColumns(part.text, languages)}
${part.gloriaPatri ? `<div class="ordo-part-gloria-patri">${renderColumns(part.gloriaPatri, languages)}</div>` : ''}
</section>