will/vu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fall back to a saint's collectCommon/collectName in commemorations too

Browse Source 
sanctoralCommemorationPart() only ever checked a commemorated saint's
own propers, so a saint like St. Sabina — no propers of her own, but
a real collectCommon + collectName template fallback, verified text
and all — rendered as an outright "missing" commemoration. The day's
primary-collect resolver (getDayCollect) already had this same
collectCommon/collectName fallback tier; this brings the
commemoration path in line with it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VFGHb4XMe6Wya4pGpPhEEi
This commit is contained in:
Will Estes
2026-08-29 07:33:30 -04:00
parent a3a9d568ed
commit 7ab517cbe3
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hours/resolve-common.ts
+10 -1
View File
@@ -542,7 +542,16 @@ function sanctoralCommemorationPart(commemoration: Extract<Commemoration, { kind
if (combined.status.la !== 'missing' || combined.status.en !== 'missing') { if (combined.status.la !== 'missing' || combined.status.en !== 'missing') {
return { kind: 'preces', text: combined, label }; return { kind: 'preces', text: combined, label };
} }
return { kind: 'preces', text: resolveCommon(`${saint.propers}-collect`), label }; const properCollect = resolveCommon(`${saint.propers}-collect`);
if (properCollect.status.la !== 'missing' || properCollect.status.en !== 'missing') {
return { kind: 'preces', text: properCollect, label };
}
}
if (saint?.collectCommon && saint.collectName) {
const template = resolveCommon(saint.collectCommon);
if (template.status.la !== 'missing' || template.status.en !== 'missing') {
return { kind: 'preces', text: substituteName(template, saint.collectName), label };
}
} }
return { kind: 'preces', text: { text: {}, status: { la: 'missing', en: 'missing' } }, label }; return { kind: 'preces', text: { text: {}, status: { la: 'missing', en: 'missing' } }, label };
} }