Don't commemorate a Vigil alongside the very feast it anticipates
At Vespers/Compline, a day's own Vigil losing tonight to tomorrow's First Vespers was showing up as a redundant extra commemoration alongside that same feast (e.g. Nov 29's Compline showing both "St. Andrew" and "Vigil of St. Andrew" for Advent I's anticipated evening). Added an explicit `vigilOf` field to each Vigil's own saint record (several Vigil ids don't map cleanly to their feast's id by stripping a `vigil-of-` prefix — `vigil-of-the-assumption` vs `assumption`, `vigil-of-st-james` vs `st-james-the-greater` — so this needs to be explicit rather than guessed from the id or date adjacency). calendar/vespers.ts's evening-anticipation merge now skips adding the Vigil commemoration when tomorrow's winner or its own commemorations already include that same feast. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -78,6 +78,16 @@ export interface SaintRecord {
|
||||
/** See calendar/types.ts's OctaveConfig doc comment. Absent for the vast
|
||||
* majority of saints — only ones with a real octave declare it. */
|
||||
octave?: OctaveConfig;
|
||||
/** For a `rank: vigil` record only — the real id of the feast this is
|
||||
* the eve of (e.g. `st-andrew`, not derivable from this record's own id
|
||||
* by stripping a `vigil-of-` prefix: several vigils' ids don't match
|
||||
* their feast's id exactly — `vigil-of-the-assumption` vs `assumption`,
|
||||
* `vigil-of-st-james` vs `st-james-the-greater`). Lets
|
||||
* calendar/vespers.ts's evening-anticipation merge recognize "today's
|
||||
* Vigil is being displaced by the very feast it's the eve of" precisely
|
||||
* (rather than guessing from date adjacency alone) and skip
|
||||
* commemorating the Vigil redundantly alongside its own feast. */
|
||||
vigilOf?: string;
|
||||
}
|
||||
|
||||
const sanctoralCalendar = sanctoralCalendarData as { days: Record<string, string[]> };
|
||||
|
||||
+34
-1
@@ -13,6 +13,7 @@ import { resolveDay } from './index';
|
||||
import { addDays } from './date-math';
|
||||
import { easterOffsetOf } from './temporal';
|
||||
import { isAtLeast } from './commemorations';
|
||||
import { getSaintRecord } from './feasts';
|
||||
|
||||
/**
|
||||
* Fixed/movable "feasts of the Lord" load-bearing elsewhere in this app
|
||||
@@ -95,6 +96,38 @@ function tagVespersFrom(tomorrow: LiturgicalDay): LiturgicalDay {
|
||||
return { ...tomorrow, winner: { ...tomorrow.winner, vespersFrom: 'firstVespersOfTomorrow' } };
|
||||
}
|
||||
|
||||
/** Today's own Vigil isn't commemorated alongside the very feast it's the
|
||||
* eve of — e.g. Nov 29's Vigil of St. Andrew shouldn't also show up next
|
||||
* to St. Andrew himself once this evening has already adopted his First
|
||||
* Vespers, whether St. Andrew governs it outright or is merely
|
||||
* commemorated there himself (2025-11-30: he's only commemorated under
|
||||
* Advent I, a `privileged-sunday`, per commemorations.ts's own threshold
|
||||
* — the Vigil would otherwise show up redundantly alongside him even
|
||||
* though neither one is tomorrow's actual winner). Matched via each
|
||||
* Vigil's own explicit `vigilOf` field (calendar/feasts.ts's
|
||||
* `SaintRecord`) against tomorrow's winner *and* its commemorations, not
|
||||
* date adjacency or name-guessing — several vigils' own ids don't map
|
||||
* cleanly to their feast's id (`vigil-of-the-assumption` vs `assumption`,
|
||||
* `vigil-of-st-james` vs `st-james-the-greater`), so this needs the
|
||||
* explicit link. Scoped to this evening-anticipation merge specifically,
|
||||
* not `commemorationOf` itself — the reverse direction
|
||||
* (`keepsOwnSecondVespers`, commemorating *tomorrow's* Vigil while today
|
||||
* keeps its own Vespers) can't hit this collision: a Vigil dated tomorrow
|
||||
* belongs to a feast the day after tomorrow, never today. */
|
||||
function isVigilOfTomorrow(today: LiturgicalDay, tomorrow: LiturgicalDay): boolean {
|
||||
if (today.winner.kind !== 'sanctoral' || today.winner.rank !== 'vigil') {
|
||||
return false;
|
||||
}
|
||||
const feastId = getSaintRecord(today.winner.id)?.vigilOf;
|
||||
if (!feastId) {
|
||||
return false;
|
||||
}
|
||||
return (
|
||||
(tomorrow.winner.kind === 'sanctoral' && tomorrow.winner.id === feastId) ||
|
||||
tomorrow.commemorations.some((c) => c.kind === 'sanctoral' && c.id === feastId)
|
||||
);
|
||||
}
|
||||
|
||||
/** The ordinary anticipation path: tag tomorrow's identity, then layer in
|
||||
* today's commemoration if it's eligible (see commemorationOf). Not used
|
||||
* by the isMajorFixedFeastOfTheLord override below — whether Christmas/
|
||||
@@ -104,7 +137,7 @@ function tagVespersFrom(tomorrow: LiturgicalDay): LiturgicalDay {
|
||||
* commemorations.ts), so it deliberately doesn't inherit this behavior. */
|
||||
function anticipated(today: LiturgicalDay, tomorrow: LiturgicalDay): LiturgicalDay {
|
||||
const tagged = tagVespersFrom(tomorrow);
|
||||
const commemoration = commemorationOf(today.winner);
|
||||
const commemoration = isVigilOfTomorrow(today, tomorrow) ? undefined : commemorationOf(today.winner);
|
||||
if (!commemoration) {
|
||||
return tagged;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user