Show a commemorated Sunday's name in the day label
collectCommemorations dropped the plain temporal commemoration name unconditionally whenever anything else won the day, treating a commemorated Sunday the same as a commemorated ferial weekday. But a Sunday isn't "just an ordinary weekday" the way a ferial Tuesday is -- it's real information a reader can't infer from the winner+rank alone, and it's exactly why a bare commemoration collect (now a full bundle, previous commit) is being said in the first place. Divino Afflatu 1954's own commemoration line for a comparable case (St. Joachim winning a Sunday, Aug 16 2026) confirms this: it names the Sunday, no octave -- restoring that instead of a 2026-09-05 change that had over-corrected past the actual rule. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGsATZvfnpQ81HQuoF5JuL
This commit is contained in:
@@ -509,12 +509,23 @@ function collectCommemorations(
|
||||
// pass wrongly scoped this to "only when an Ember commemoration is
|
||||
// also present" — user, 2026-09-05: "it has nothing to do with
|
||||
// ember-ness"); this plain generic label is dropped unconditionally
|
||||
// whenever it shows up as a mere commemoration, Ember day or not.
|
||||
// whenever it shows up as a mere commemoration on an ordinary
|
||||
// ferial weekday, Ember day or not.
|
||||
//
|
||||
// A commemorated *Sunday* is the one exception (user, 2026-09-05):
|
||||
// unlike a plain ferial Tuesday, "this is also a Sunday" is real
|
||||
// information a reader can't infer from the winner+rank alone — it's
|
||||
// why the Sunday's own collect is being said at all (getDayCollects'
|
||||
// temporalCommemorationPart), and nothing else in the header hints
|
||||
// at it. Shown via the same plain, rank-free `temporalLabel` a
|
||||
// winning Sunday would use for itself.
|
||||
if (c.id !== temporalId) {
|
||||
const emberName = emberDayLabel(c.id);
|
||||
if (emberName) {
|
||||
temporal.push(emberName);
|
||||
}
|
||||
} else if (day.weekday === 'sunday') {
|
||||
temporal.push(temporalLabel(day));
|
||||
}
|
||||
} else if (opts.showOctaves && c.id !== opts.excludeOctaveId) {
|
||||
const octave = activeOctaves.find((a) => a.id === c.id);
|
||||
|
||||
Reference in New Issue
Block a user